Repository navigation
netns: namespace handle for Linux netns files and FreeBSD jails - #7
Merged
Merged
Conversation
Introduce network::netns with a Netns type and a NetnsRef borrow. On Linux they are File and BorrowedFd, so the Linux code keeps its types and setns behavior. On FreeBSD a namespace is the VNET jail named by the netns path: Netns::open looks the jid up with jail_get, and because a process cannot leave a jail, work inside it runs in a forked child. A netlink socket for the jail is created in such a child and handed back over SCM_RIGHTS; the kernel serves netlink requests in the vnet the socket was created in. DriverInfo, the netlink CreateLinkOptions and set_link_ns take NetnsRef. The exec_netns macro keeps its Linux definition and gets a FreeBSD one that runs the block in the jail. Moving a link into a jail and creating a link inside one return "not supported yet" on FreeBSD; that is the SIOCSIFVNET ioctl, which comes with the bridge driver. The connection tester and the netlink unit tests need Linux namespaces and are gated to Linux. The netns validation looks the jail up on FreeBSD instead of opening a file, and the FreeBSD socket accepts EISCONN from connect: the kernel marks a netlink socket connected as soon as it is bound. Signed-off-by: Michael Johnson <buhnux@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce network::netns with a Netns type and a NetnsRef borrow. On
Linux they are File and BorrowedFd, so the Linux code keeps its types
and setns behavior. On FreeBSD a namespace is the VNET jail named by the
netns path: Netns::open looks the jid up with jail_get, and because a
process cannot leave a jail, work inside it runs in a forked child. A
netlink socket for the jail is created in such a child and handed back
over SCM_RIGHTS; the kernel serves netlink requests in the vnet the
socket was created in.
DriverInfo, the netlink CreateLinkOptions and set_link_ns take NetnsRef.
The exec_netns macro keeps its Linux definition and gets a FreeBSD one
that runs the block in the jail. Moving a link into a jail and creating
a link inside one return "not supported yet" on FreeBSD; that is the
SIOCSIFVNET ioctl, which comes with the bridge driver.
The connection tester and the netlink unit tests need Linux namespaces
and are gated to Linux.
The netns validation looks the jail up on FreeBSD instead of opening a
file, and the FreeBSD socket accepts EISCONN from connect: the kernel
marks a netlink socket connected as soon as it is bound.